Yes, however only in the scope of 'lib/ipmi_raw.c'. But I'm quite against moving such functions, is_valid_param() or is_fruid(), into 'lib/helper.c'. I see a little benefit in making 'lib/helper.c' bigger.
I'll commit in a bit then. Z. On Fri, Nov 16, 2012 at 2:21 PM, Andy Cress <andy.cr...@us.kontron.com> wrote: > Z, > > I think that's much better. > And if other code needs similar rework, it will make that task easier now. > > Andy > > -----Original Message----- > From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com] > Sent: Friday, November 16, 2012 1:18 AM > To: Andy Cress > Cc: ipmitool-devel > Subject: Re: [Ipmitool-devel] Code Review - ID: 3528347 - 'lib/ipmi_raw.c' > -possible int *flow > > Here we go. Final. > > Z. > > On Thu, Nov 15, 2012 at 10:21 PM, Andy Cress <andy.cr...@us.kontron.com> > wrote: >> Z, >> >> Yes, that would allow all of the logic to be in the subroutine. >> >> Andy >> >> -----Original Message----- >> From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com] >> Sent: Thursday, November 15, 2012 3:20 PM >> To: Andy Cress >> Cc: ipmitool-devel >> Subject: Re: [Ipmitool-devel] Code Review - ID: 3528347 - >> 'lib/ipmi_raw.c' -possible int *flow >> >> Andy, >> >> do you mean something like: >> ~~~ >> is_valid_param(argv[i], ¶m_store_ptr, "param_label") ~~~ >> >> where "param_label" is going to be used in error messages: >> ~~~ >> printf(LOG_ERR, "Given %s \"%s\" is invalid.", ...); ~~~ ? >> >> Regards, >> Z. >> >> On Thu, Nov 15, 2012 at 5:41 PM, Andy Cress <andy.cr...@us.kontron.com> >> wrote: >>> Z, >>> >>> Way too much bloat. >>> Put all that in one subroutine. >>> >>> Andy >>> >>> -----Original Message----- >>> From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com] >>> Sent: Thursday, November 15, 2012 1:03 AM >>> To: ipmitool-devel >>> Subject: [Ipmitool-devel] Code Review - ID: 3528347 - >>> 'lib/ipmi_raw.c' -possible int *flow >>> >>> Hello, >>> >>> attached is a proposed fix for *flows in 'lib/ipmi_raw.c'. I'd say nothing >>> complicated. However, I'm wondering about 'netfn'. >>> >>> I'd like to commit this very soon and move on. >>> >>> Thanks, >>> Z. ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
