On 11/18/2012 11:49 PM, Zdenek Styblik wrote:
> On Fri, Nov 16, 2012 at 4:26 PM, <charles_r...@dell.com> wrote:
>> On 11/05/2012 05:00 PM, Rose, Charles wrote:
>>> On 11/01/2012 11:23 PM, ^..^ wrote:
>>>>
>>>> Agree w. Z; you could check for success/fail on that line. A few minor
>>>> additional comments (I
>>>> didn't run it, just looked at it, since I didn't have the patch installed
>>>> to try):
>>>
>>> Thanks for the review and suggestions. I have uploaded script v0.7 to the
>>> tracker for review.
>>>
>>
>> Please let me know if there are any more comments/suggestions for
>> improvement of the script. I would
>> like to have this committed to CVS soon.
>>
>> --
>> Thanks,
>> Charles Rose
>
> Charles,
>
> ``# v1.8.12 plus patches are required for getsysinfo support'' <<<
> what patches???
http://sourceforge.net/mailarchive/message.php?msg_id=29647222
I have added this URL to the comment.
>
> ~~~
> OUTPUT="echo" -> OUTPUT="printf -- %s\n"
> echo ${TMP_URL}'' -> ``printf -- "%s" "${TMP_URL}"
> echo ${TMP_IPv4} -> same as above
> ~~~
Thanks. Changed.
>
> It would be nice to mention how and where to implement other BMC
> Manufacturer's ID, eg. ``see function X and Y for implementation''.
>
Added details on OEM commands.
# OEM Specific: OEM specific ipmi commands go in:
# 'oem_set_os_version' and 'oem_get_bmc_url'
...
case "${BMC_VENDOR}" in
$DELL) ${IPMI_SET_SYSINFO} delloem_os_version \
"${OS_VERSION}" > /dev/null 2>&1
return $?
;;
# Add OEM specific commands.
# Example:
# $OTHER_OEM) ${IPMI_SET_SYSINFO} otheroem_os_version \
# "${OS_VERSION}" > /dev/null 2>&1
# return $?
# ;;
*) return 0
;;
v0.72 contains these changes. Uploaded to the tracker 3571445.
> My $0.02USD
>
> Best regards,
> Z.
>
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
