Ales, I'm wondering whether this wouldn't be better/nicer/more portable(?):
~~~ diff -u -r1.43 ipmi_chassis.c --- lib/ipmi_chassis.c 20 Feb 2013 14:35:07 -0000 1.43 +++ lib/ipmi_chassis.c 20 Feb 2013 17:37:38 -0000 @@ -132,7 +132,7 @@ struct { uint8_t interval; uint8_t force_on; - } identify_data = { .interval = 0, .force_on = 0 }; + } identify_data = {0}; ~~~ Z. On Wed, Feb 20, 2013 at 4:12 PM, Zdenek Styblik <zdenek.styb...@gmail.com> wrote: > Got it. It looks awkward though :) > > Zdenek > > > On Wed, Feb 20, 2013 at 3:55 PM, Ales Ledvinka <aledv...@redhat.com> wrote: >> Compile time error. >> >> ----- Original Message ----- >> From: "Zdenek Styblik" <zdenek.styb...@gmail.com> >> To: "Ales Ledvinka" <aledv...@redhat.com> >> Cc: ipmitool-devel@lists.sourceforge.net >> Sent: Wednesday, February 20, 2013 3:41:16 PM >> Subject: Re: [Ipmitool-cvs] ipmitool/lib ipmi_chassis.c, 1.42, 1.43 >> ipmi_delloem.c, 1.23, 1.24 >> >> Ales, >> >> what's the reason for changes to 'lib/ipmi_chassis.c'??? >> >> Thanks, >> Zdenek >> >> On Wed, Feb 20, 2013 at 3:35 PM, Ales Ledvinka >> <le...@users.sourceforge.net> wrote: >>> Update of /cvsroot/ipmitool/ipmitool/lib >>> In directory sfp-cvs-1.v30.ch3.sourceforge.com:/tmp/cvs-serv19457/lib >>> >>> Modified Files: >>> ipmi_chassis.c ipmi_delloem.c >>> Log Message: >>> compile fix. see previous revision diff and comment for code change reason >>> >>> >>> Index: ipmi_delloem.c >>> =================================================================== >>> RCS file: /cvsroot/ipmitool/ipmitool/lib/ipmi_delloem.c,v >>> retrieving revision 1.23 >>> retrieving revision 1.24 >>> diff -C2 -d -r1.23 -r1.24 >>> *** ipmi_delloem.c 20 Feb 2013 12:17:58 -0000 1.23 >>> --- ipmi_delloem.c 20 Feb 2013 14:35:07 -0000 1.24 >>> *************** >>> *** 668,672 **** >>> lprintf(LOG_ERR, " Error getting platform model >>> name"); >>> break; >>> ! } else if (rc_tmp > 0) { >>> lprintf(LOG_ERR, " Error getting platform model >>> name: %s", >>> val2str(rc, completion_code_vals)); >>> --- 668,672 ---- >>> lprintf(LOG_ERR, " Error getting platform model >>> name"); >>> break; >>> ! } else if (rc > 0) { >>> lprintf(LOG_ERR, " Error getting platform model >>> name: %s", >>> val2str(rc, completion_code_vals)); >>> >>> Index: ipmi_chassis.c >>> =================================================================== >>> RCS file: /cvsroot/ipmitool/ipmitool/lib/ipmi_chassis.c,v >>> retrieving revision 1.42 >>> retrieving revision 1.43 >>> diff -C2 -d -r1.42 -r1.43 >>> *** ipmi_chassis.c 16 Jan 2013 14:28:39 -0000 1.42 >>> --- ipmi_chassis.c 20 Feb 2013 14:35:07 -0000 1.43 >>> *************** >>> *** 131,137 **** >>> >>> struct { >>> ! uint8_t interval = 0; >>> ! uint8_t force_on = 0; >>> ! } identify_data; >>> >>> memset(&req, 0, sizeof(req)); >>> --- 131,137 ---- >>> >>> struct { >>> ! uint8_t interval; >>> ! uint8_t force_on; >>> ! } identify_data = { .interval = 0, .force_on = 0 }; >>> >>> memset(&req, 0, sizeof(req)); >>> >>> >>> ------------------------------------------------------------------------------ >>> Everyone hates slow websites. So do we. >>> Make your web apps faster with AppDynamics >>> Download AppDynamics Lite for free today: >>> http://p.sf.net/sfu/appdyn_d2d_feb >>> _______________________________________________ >>> Ipmitool-cvs mailing list >>> ipmitool-...@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/ipmitool-cvs ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel