Right, overlooked the N if the ifndef completely and focused at the message
text.
----- Original Message -----
From: "Zdenek Styblik" <zdenek.styb...@gmail.com>
To: "Ales Ledvinka" <aledv...@redhat.com>
Cc: "ipmitool-devel" <ipmitool-devel@lists.sourceforge.net>
Sent: Thursday, March 14, 2013 10:40:46 AM
Subject: Re: [Ipmitool-devel] Code Review - ID: 3603419 - 'lib/ipmi_dcmi.c' -
waste of resources
On Thu, Mar 14, 2013 at 10:15 AM, Ales Ledvinka <aledv...@redhat.com> wrote:
> Hello,
>
> This seems to be a bit more user friendly.
> s/when LANplus(IPMI v2.0)/with -I lanplus/
>
Ales,
adding '-l lanplus' won't change anything at that point, because
discovery feature hasn't been compiled in. I'm not arguing the text
I've committed is the best in the world(it probably isn't). But I'm
saying '-l lanplus' won't help the user, because he doesn't have LAN+
support compiled in. I was even thinking about stating this in error
message, but I wasn't sure/convinced it would make sense to the
user("Compilation? Huh?").
Anyway, if you have better suggestion for error message, please, log
new SF.net ticket.
Thanks,
Z.
> ----- Original Message -----
> From: "Zdenek Styblik" <zdenek.styb...@gmail.com>
> To: "ipmitool-devel" <ipmitool-devel@lists.sourceforge.net>
> Sent: Thursday, March 7, 2013 8:49:37 PM
> Subject: [Ipmitool-devel] Code Review - ID: 3603419 - 'lib/ipmi_dcmi.c' -
> waste of resources
>
> Hello all,
>
> this is a low hanging fruit bug and pretty much the only reason I'm
> asking for review is the change in error message that will be printed
> out.
>
> Are we happy with the changes?
>
> Thanks,
> Z.
>
> ------------------------------------------------------------------------------
> Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
> Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the
> endpoint security space. For insight on selecting the right partner to
> tackle endpoint security challenges, access the full report.
> http://p.sf.net/sfu/symantec-dev2dev
> _______________________________________________
> Ipmitool-devel mailing list
> Ipmitool-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
