Z, Thanks for the commit. Ideally we would want smaller patches. Helps in getting it reviewed better... ;) since we are not doing anything major in terms of features or change in functionality, we should be able to go ahead with it unless there are no issues checking in the code(I don't have permission to commit :( )
ll try and test whatever is possible from my side Appreciate your efforts. Cheers, G On 03/20/2013 04:48 PM, Zdenek Styblik wrote: > Hello G, > > I don't have access to Dell hardware, so I haven't done any testing > beyond compilation. I'll check some(= not all of them) help outputs > later, but that's the most I can do right now. > I have some changes in the code planned, but I don't intend to change > functionality per se. To be more precise, I mean CLI interface > functionality that is. However, I have to turn my attention to other > issues right now. > I promise future changes will be in small portions as usual. It didn't > make sense to do this change in smaller chunks, although it still can > be split into smaller commits. But I'm not sure if this idea is worth > of time and effort and whether it makes sense at all. > > If you could do some testing, it would be great. And I won't deny it > would save me some time too. > > Cheers, > Z. > > On Wed, Mar 20, 2013 at 11:12 AM, <srinivas_g_go...@dell.com> wrote: >> Hi Z, >> Appreciate your effort :) >> Happy to see that there are no functionality changes ;) >> >> Wanted to know if there was any type of sanity test carried out with >> this patch ? >> >> >> Thanks, >> G >> >> On 03/20/2013 01:56 PM, Zdenek Styblik wrote: >>> Hello, >>> >>> attached is a diff which changes code formatting in >>> 'lib/ipmi_delloem.c' and some typos here and there. No functional >>> changes were made, not willingly. >>> It's 8k lines of diff, though. >>> >>> Thanks, >>> Z. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
