Hi Zdenek,
On Fri, Mar 22, 2013 at 9:12 AM, Zdenek Styblik
<zdenek.styb...@gmail.com> wrote:
> Hello all,
>
> attached is a rather large diff which sets all pointers in ipmitool to
> NULL right after free() is called. The aim of the patch is not to
> investigate whether there these pointers are being freed elsewhere
> again!
>
> Who is up for review?
> 1] check whether really all of ``free(p); p = NULL;'' are handled
Not entirely clear really....
If I do this in the ipmitool cvs tree:
find . -name '*.c' |xargs egrep free.?\\\(|wc
I get:
dg:speedy:ipmitool(master) => find . -name '*.c' |xargs egrep free.?\\\(|wc
257 518 10039
Then count the free()'s from the patch:
dg:speedy:ipmitool(master) => grep free
~/Downloads/ipmitool-set_freed_p_to_null.diff|wc
245 284 4960
So, they don't match, but it's not clear where it's missing.
> 2] whether anything else is missing or is wrong
> 3] anything else :)
I guess I just don't really see what the point of this patch is. Is
there a bug somewhere where free'd memory is being accessed? If so,
it's probably better to just try and fix that.
Although these changes don't really hurt anything they do clutter
things up quite a bit and don't have any effect in 99% of the cases.
Memory leaks on the other hand... Those should be addressed. There
are tons in ipmi_ekanalyzer(). I fixed most of them, but broke some
other stuff in the process and haven't had time to go back and fix it.
thanks
dan
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
