Hello, Zdenek,
Are there any other comments to the patch or I can treat it is accepted?
Regards,
Dmitry
19.04.2013 12:56, Dmitry Bazhenov пишет:
> Zdenek,
>
> I corrected the indentation and formatting. Please, review.
>
> Regards,
> Dmitry
>
> 18.04.2013 17:03, Zdenek Styblik пишет:
>> On Thu, Apr 18, 2013 at 8:00 AM, Dmitry Bazhenov
>> <dim...@pigeonpoint.com> wrote:
>>> Hello, all,
>>>
>>> The attached patch adds a OEM handle and workaround code for Intel
>>> i82751
>>> MAC working in the super pass-though mode which has known deviations
>>> in its
>>> RMCP+ implementation. With the OEM handle active, IPMITool can
>>> successfully
>>> interact with this Intel 82751-based boards.
>>>
>>> Please, review.
>>>
>>> Regards,
>>> Dmitry
>>>
>>
>> Hi,
>>
>> it's hard to say, but it seems to me the following diffs have wrong
>> indentation:
>> @@ -1568,6 +1568,8 @@ ipmi_sol_red_pill(struct ipmi_intf * int
>> FD_SET(0, &read_fds);
>> FD_SET(intf->fd, &read_fds);
>>
>> + if (!ipmi_oem_active(intf,"i82571spt"))
>> + {
>> /* Send periodic keepalive packet */
>> if(_use_sol_for_keepalive == 0)
>> {
>> @@ -1604,7 +1606,7 @@ ipmi_sol_red_pill(struct ipmi_intf * int
>> /* if the keep Alive is successful reset retries to zero */
>> retrySol = 0;
>> }
>> -
>> + } /* !oem="i82571spt" */
>> /* Wait up to half a second */
>> tv.tv_sec = 0;
>> tv.tv_usec = 500000;
>> ~~~
>>
>> And since the following is getting changed:
>> @@ -460,7 +469,7 @@ int lanplus_generate_rakp3_authcode(uint
>> * returns 0 on success
>> * 1 on failure
>> */
>> -int lanplus_generate_sik(struct ipmi_session * session)
>> +int lanplus_generate_sik(struct ipmi_session * session, struct
>> ipmi_intf * intf)
>> {
>> uint8_t * input_buffer;
>> int input_buffer_length, i;
>> ~~~
>>
>> change it to(just an example what I mean and can be done by person
>> doing commit):
>> @@ -460,7 +469,8 @@ int lanplus_generate_rakp3_authcode(uint
>> * returns 0 on success
>> * 1 on failure
>> */
>> -int lanplus_generate_sik(struct ipmi_session * session)
>> +int
>> +lanplus_generate_sik(struct ipmi_session * session, struct ipmi_intf
>> * intf)
>> {
>> uint8_t * input_buffer;
>> int input_buffer_length, i;
>> ~~~
>>
>> Thanks,
>> Z.
>>
>
>
> ------------------------------------------------------------------------------
> Precog is a next-generation analytics platform capable of advanced
> analytics on semi-structured data. The platform includes APIs for building
> apps and a phenomenal toolset for data science. Developers can use
> our toolset for easy data analysis & visualization. Get a free account!
> http://www2.precog.com/precogplatform/slashdotnewsletter
>
>
>
> _______________________________________________
> Ipmitool-devel mailing list
> Ipmitool-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
