Hi all, attached is a diff which replaces atoi()/strto*() calls in 'lib/ipmi_picmg.c' either with wrapper functions or str2*() calls. Also, range limits are being applied to input values and it should be possible to input hex/octal values now(ID#3611253). Note, however, comments in diff need a clean-up and there is a lack of documentation now. But it will be there for the finals.
Now, I've used Emerson's AMC specification[1] for limits. However, I'm not sure nor convinced whether it's PICMG/AMC specification or just Emerson specification/implementation. I couldn't find any PICMG limits, resp. IPMI-PICMG specification, though. If somebody has real-life experience with PICMG and knows what values, resp. what range of values is expected, please, let me know. Eg. values for Device ID, Port and Interface aren't being checked beyond whether it's some kind of integer. I don't know what limits should apply here, because I couldn't find any. Thanks, Z. [1] http://www.emersonnetworkpower.com/en-US/Products/EmbeddedComputing/Documents/DocumentationArchive/TechnicalDocumentation/01/6806800G28B_AMC9210_IPMI_PR.pdf
ipmi_picmg.c-fix_flows.diff
Description: Binary data
------------------------------------------------------------------------------ Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET Get 100% visibility into your production application - at no cost. Code-level diagnostics for performance bottlenecks with <2% overhead Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
