I was just reviewing the get_lan_param_select() code in lib/ipmi_lanp.c
and I think I found a bug:
for (i = 0; ipmi_lan_params[i].cmd != (-1); i++) {
if (ipmi_lan_params[i].cmd == param) {
p = &ipmi_lan_params[param];
break;
}
}
The 3rd line should use i for the array index, not param:
- p = &ipmi_lan_params[param];
+ p = &ipmi_lan_params[i];
The param value matches the cmd in the lan_param struct, but it's not
the same as the ipmi_lan_params[] array index.
Thanks!
Jeff Bastian
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
