On Thu, Aug 29, 2013 at 9:37 AM, Liebig, Holger <holger.lie...@ts.fujitsu.com> wrote: > Jim, > any chance to include my small patch from 2011 regarding SOL input buffer > size? > The problem is related when a user is using copy&paste and is pasting large > blocks of text (>255) into the ipmitool SOL session at once. Ipmitool is > using the reported SOL max inbound payload size for the allocated data buffer > size, but is not accounting for the standard 4 byte SOL header which is part > of the payload. So, when the BMC is reporting a SOL payload size of 259 (255 > max ACK'able characters/bytes + 4byte for the header) ipmitool is using a > buffer of 259 characters for text to send at once. > > The problem was reported by a customer and the fix has been integrated into > Red Hat's version of ipmitool. > > Problem description: > https://access.redhat.com/site/solutions/63758 > > Solution (need an account) > https://bugzilla.redhat.com/show_bug.cgi?id=675980 > > Thanks, > Holger >
Holger, release of 1.8.13 was announced well ahead, there was plenty of time etc. etc. No, no more fixes into 1.8.13. It's 28th August and we could do this forever - until all bugs and problems are fixed and everybody is satisfied which is never. Thanks for understanding, Z. > > -----Original Message----- > From: Jim Mankovich [mailto:jm...@hp.com] > Sent: Monday, August 26, 2013 7:25 PM > To: ipmitool-devel@lists.sourceforge.net > Subject: [Ipmitool-devel] ipmitool 1.8.13rc1 release is available > > All, > > I uploaded an updated preliminary release of ipmitool 1.8.13 for testing to > the source forge ipmitool files repository. > > https://sourceforge.net/projects/ipmitool/files/ipmitool/1.8.13rc1/ > > The 1.8.13rc1 release currently contains all the changes we had planned to > include into 1.8.13, so if there are no defects filed against > 1.8.13rc0 or 1.8.13rc1, what is in rc1 will become the released bits for > 1.8.13 in early September. > > Thanks, > Jim > > -- > --- Jim Mankovich | jm...@hp.com (US Mountain Time) --- > > > ------------------------------------------------------------------------------ > Introducing Performance Central, a new site from SourceForge and > AppDynamics. Performance Central is your source for news, insights, > analysis and resources for efficient Application Performance Management. > Visit us today! > http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > > > ---------- Forwarded message ---------- > From: "Liebig, Holger" <holger.lie...@ts.fujitsu.com> > To: "ipmitool-devel@lists.sourceforge.net" > <ipmitool-devel@lists.sourceforge.net> > Cc: Jan Safranek <jsafr...@redhat.com> > Date: Tue, 8 Feb 2011 14:08:04 +0100 > Subject: [Ipmitool-devel] [PATCH] SOL input buffer size > Hi, > The following patch fixes an issue where ipmitool is potentially sending to > much input data to the BMC with a single SOL packet. Depending on the BMC's > implementation, this can lead to multiple echo's of the characters at the > end, or an endless retry loop from the BMC. > > Best Regards, > Holger Liebig > > diff -Nur ipmitool.sav/lib/ipmi_sol.c ipmitool/lib/ipmi_sol.c > --- ipmitool.sav/lib/ipmi_sol.c 2009-01-18 14:53:12.000000000 +0100 > +++ ipmitool/lib/ipmi_sol.c 2011-02-08 13:45:51.574399671 +0100 > @@ -1537,6 +1537,10 @@ > int keepAliveRet = 0; > int retrySol = 0; > > + /* Subtract SOL header from max_inbound_payload_size */ > + if (buffer_size > 4) > + buffer_size -= 4; > + > buffer = (char*)malloc(buffer_size); > if (buffer == NULL) { > lprintf(LOG_ERR, "ipmitool: malloc failure"); > > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
