On 31 Jan 2014 15:18, "Petter Reinholdtsen" <p...@hungry.com> wrote:
>
> [Zdenek Styblik]
> >> Either I'm missing something, or your patch is wrong. Either way, I
> >> really don't like your approach to this problem. I'm sorry, but this
> >> is fugly.
> >
> > Please, just declare new variable, be it rv_readline, with type of int
> > and don't do things which cause a sudden need to suffocate myself with
> > a big black whooper ;)
>
> Thank you for the feedback. Now we know you do not like the approach.
> But based on what you wrote, it is not possible to understand what it
> is with the approach you do not like. Can you tell us a bit more?
Sure. Not only you're reusing variable name, you're declaring it deep
inside the function/code. So no.
Z.
>
> --
> Happy hacking
> Petter Reinholdtsen
>
>
------------------------------------------------------------------------------
> WatchGuard Dimension instantly turns raw network data into actionable
> security intelligence. It gives you real-time visual feedback on key
> security issues and trends. Skip the complicated setup - simply import
> a virtual appliance and go from zero to informed in seconds.
>
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
> _______________________________________________
> Ipmitool-devel mailing list
> Ipmitool-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
