On Mon, Mar 3, 2014 at 10:20 AM, Mamatha Inamdar
<mamat...@linux.vnet.ibm.com> wrote:
[...]
> Signed-off-by: Mamatha Inamdar <mamat...@linux.vnet.ibm.com>
> ---
> lib/ipmi_sel.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/ipmi_sel.c b/lib/ipmi_sel.c
> index 63ecbcf..0393a99 100644
> --- a/lib/ipmi_sel.c
> +++ b/lib/ipmi_sel.c
> @@ -2898,7 +2898,11 @@ ipmi_sel_show_entry(struct ipmi_intf * intf, int argc,
> char ** argv)
> lprintf(LOG_DEBUG, "Looking up SEL entry 0x%x", id);
>
> /* lookup SEL entry based on ID */
> - ipmi_sel_get_std_entry(intf, id, &evt);
> + if(!ipmi_sel_get_std_entry(intf, id, &evt)) {
> + lprintf(LOG_DEBUG, "SEL Entry %d not found", id);
> + return -1;
> + }
> +
> if (evt.sel_type.standard_type.sensor_num == 0 &&
> evt.sel_type.standard_type.sensor_type == 0 && evt.record_type == 0) {
> lprintf(LOG_WARN, "SEL Entry 0x%x not found", id);
> rc = -1;
>
Hello Mamatha,
I believe you're patch is incorrect as 'sel get' actually accepts
multiple SEL IDs. Therefore, it should be:
~~~
rc = (-1);
continue;
~~~
instead of:
~~~
return (-1);
~~~
Best regards,
Z.
------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works.
Faster operations. Version large binaries. Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
