> > All, > > I have created the 1.8.14 RC1 release bundles and they are now available > on sourceforge.net at the following URL. > https://sourceforge.net/projects/ipmitool/files/ipmitool/1.8.14-rc1/ > > We would appreciate if the ipmitool developers and users could take some > time and test out the request for comment release and provide us some > feedback via the ipmitool-devel alias. > > Many thanks to everyone that contributed to this release, Jim > > -- > --- Jim Mankovich | jm...@hp.com (US Mountain Time) --- >
[Liebig, Holger] This reminded me that I never got back with the DCMI issues I reported some time ago just before the 1.813 release. The current code does not allow to specify a DCMI power limit action (e.g. 'ipmitool dcmi power set_limit action power_off' will not work since this is parsed as integer with the str2uint() construct in line 1459). The attached patch proposal fixes this as well as allowing 'no_action' and any oem actions (if supported by the BMC). Let me know if I need to file an additional bug report / patch proposal (there seems to be 2 already open as 144 / 291) Best Regards, Holger Liebig
--- Begin Message ---On Mon, Sep 9, 2013 at 5:14 PM, Liebig, Holger <holger.lie...@ts.fujitsu.com> wrote: > [Liebig, Holger] > Just a heads up: > unfortunately the change breaks 'ipmitool dcmi power set_limit action > power_off' due to the test for a valid integer value at the beginning of the > ipmi_dcmi_pwr_slimit() function which should be valid only for the numeric > options. > > Also, the dcmi_pwrmgmt_action_vals array has only the long description > strings and no value strings, so the above command would still fail without > additional work and last but not least, 'no_action' cannot be specified. > > Since the window for the 1.8.13 is most likely closed, these should be > documented as limitations/known bugs somewhere. I will provide a patch > proposal, but would like to check the other stuff as well before sending it. > > Holger I can't come up with anything else, but ... funny, very funny. Best regards, Z.
--- End Message ---
dcmi.diff
Description: dcmi.diff
------------------------------------------------------------------------------
_______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
