On Tue, May 20, 2014 at 10:05 AM, Amelkin, Aleksandr <aleksandr.amel...@t-platforms.ru> wrote: > Specifically, the patch does the following: > 1. Fixes incorrect behavior on FRUs without Internal Use Area (which > is allowed by the specification) > > 2. Corrects size calculation for Internal Use Area (finds the start of > the actual next section instead of blindly assuming that the next section is > Chasiss Info) > > 3. Reduces the amount of copy/pasted code and magic numbers > > 4. Corrects error messages to say the truth (that it couldn’t read > something) instead of spitting out false claims (that something was > “invalid”). > > 5. Reduces nesting level by getting rid of “while(0)/break” in favor > of simple “goto”.
Sounds good. It patches against Git tip too, which is good as well. > > It’s a pity that 1.8.14 now doesn’t allow calling ‘ekanalyzer frushow > sm=<filename>’ without specifying > a full set of target options, for the aforementioned ekanalyzer command > doesn’t need them anyway and operates on a local file. > But that’s another patch, I guess. J > > Another thing I would suggest to put on the ToDo list is adding checksum > checking to this code. > Feel free to do both of those. It's not like there is some corporation pouring resources into active development of ipmitool. None that I know of. Regards, Z. > With best regards – > > Alexander Amelkin > > > ------------------------------------------------------------------------------ > "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE > Instantly run your Selenium tests across 300+ browser/OS combos. > Get unparalleled scalability from the best Selenium testing platform > available > Simple to use. Nothing to install. Get started now for free." > http://p.sf.net/sfu/SauceLabs > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
