Hi,
I have some bug fixes in this patch. Please do the needful.
--
regards
Partha
>From 737b801768d9904f5e33886356a0741f6b1f0ab3 Mon Sep 17 00:00:00 2001
From: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvara...@ericsson.com>
Date: Wed, 3 Sep 2014 09:42:11 +0200
Subject: [PATCH 1/4] delete duplicate macros
Change-Id: Ie219c955c4644b8ab9822fd1e5523d70038b5261
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvara...@ericsson.com>
---
include/ipmitool/ipmi_sdr.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/ipmitool/ipmi_sdr.h b/include/ipmitool/ipmi_sdr.h
index 724d0cd..ccf0cf0 100644
--- a/include/ipmitool/ipmi_sdr.h
+++ b/include/ipmitool/ipmi_sdr.h
@@ -102,8 +102,6 @@ enum {
#define GET_SENSOR_EVENT_STATUS 0x2b
#define GET_SENSOR_READING 0x2d
#define GET_SENSOR_TYPE 0x2f
-#define GET_SENSOR_READING 0x2d
-#define GET_SENSOR_TYPE 0x2f
#ifdef HAVE_PRAGMA_PACK
#pragma pack(1)
--
1.9.0
>From bee3fda65617f892e1a131f1cecb2933c4425d97 Mon Sep 17 00:00:00 2001
From: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvara...@ericsson.com>
Date: Wed, 3 Sep 2014 09:44:57 +0200
Subject: [PATCH 2/4] update result ptr before return
Change-Id: If976f5c769d8ba83eefa1693e6969ef17f357ba8
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvara...@ericsson.com>
---
lib/helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/helper.c b/lib/helper.c
index 4b903b0..95d641e 100644
--- a/lib/helper.c
+++ b/lib/helper.c
@@ -357,6 +357,7 @@ int str2char(const char *str, int8_t * chr_ptr)
if (arg_long < INT8_MIN || arg_long > INT8_MAX) {
return (-3);
}
+ *chr_ptr = (uint8_t)arg_long;
return 0;
} /* str2char(...) */
--
1.9.0
>From a6f34c9029a17bbd2da5ac51831a810aae3193e6 Mon Sep 17 00:00:00 2001
From: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvara...@ericsson.com>
Date: Wed, 3 Sep 2014 09:53:56 +0200
Subject: [PATCH 3/4] fix incorrect data validation
Change-Id: I6c277b4716445e8ae9a6851cca48e1ad95df49b4
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvara...@ericsson.com>
---
src/plugins/open/open.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/plugins/open/open.c b/src/plugins/open/open.c
index 92b6f37..ebbfa09 100644
--- a/src/plugins/open/open.c
+++ b/src/plugins/open/open.c
@@ -227,7 +227,7 @@ ipmi_openipmi_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req)
fprintf(stderr, "Converting message:\n");
fprintf(stderr, " netfn = 0x%x\n", req->msg.netfn );
fprintf(stderr, " cmd = 0x%x\n", req->msg.cmd);
- if (recv.msg.data && recv.msg.data_len) {
+ if (req->msg.data && req->msg.data_len) {
fprintf(stderr, " data_len = %d\n", req->msg.data_len);
fprintf(stderr, " data = %s\n",
buf2str(req->msg.data,req->msg.data_len));
--
1.9.0
>From 1b5cd2c7e9b6eabe8df115cde1a74521e8f344e0 Mon Sep 17 00:00:00 2001
From: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvara...@ericsson.com>
Date: Wed, 3 Sep 2014 10:01:07 +0200
Subject: [PATCH 4/4] print message header and data in verbose print
Change-Id: I613e35e180c815279d2a50f44956a5ed5bf5461b
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvara...@ericsson.com>
---
src/plugins/open/open.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/plugins/open/open.c b/src/plugins/open/open.c
index ebbfa09..f947c1f 100644
--- a/src/plugins/open/open.c
+++ b/src/plugins/open/open.c
@@ -188,9 +188,14 @@ ipmi_openipmi_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req)
if (intf->open(intf) < 0)
return NULL;
- if (verbose > 2)
- printbuf(req->msg.data, req->msg.data_len,
- "OpenIPMI Request Message");
+ if (verbose > 2) {
+ fprintf(stderr, "OpenIPMI Request Message Header:\n");
+ fprintf(stderr, " netfn = 0x%x\n", req->msg.netfn );
+ fprintf(stderr, " cmd = 0x%x\n", req->msg.cmd);
+ printbuf(req->msg.data, req->msg.data_len, "OpenIPMI Request Message Data");
+ }
+
+
/*
* setup and send message
--
1.9.0
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
