---------------------------------------- > Date: Wed, 2 Sep 2015 19:09:35 +0200 > Subject: Re: [Ipmitool-devel] [PATCH] New PEF policy framework > From: zdenek.styb...@gmail.com > To: jordan_hargr...@hotmail.com > CC: ipmitool-devel@lists.sourceforge.net; p...@sgi.com > > On Wed, Sep 2, 2015 at 6:21 PM, hotmail <jordan_hargr...@hotmail.com> wrote: >> >> >>> Date: Thu, 20 Aug 2015 18:49:08 +0200 >>> Subject: Re: [Ipmitool-devel] [PATCH] New PEF policy framework >>> From: zdenek.styb...@gmail.com >>> To: jordan_hargr...@hotmail.com >>> CC: ipmitool-devel@lists.sourceforge.net; p...@sgi.com >>> >>> On Mon, Aug 17, 2015 at 10:46 PM, Jordan Hargrave >>> wrote: >>>> Some time ago I proposed a patch to enable enabling/disabling individual >>>> PEF policy entries. >>>> Support for this is needed for one of our utilities. A new rework of the >>>> whole PEF framework was >>>> requested. I'm attaching a patch that (partially) implements this new >>>> scheme, please review. >>>> >>> >>> Hello Jordan, >>> >>> I'm not aware that rework of the whole PEF framework was prerequisite >>> for the patch you've posted. Patch you've posted has been rejected >>> because 'setpolicy' didn't and doesn't make sense in broad view. As a >>> follow up, new CLI PEF interface with "99%" coverage has been proposed >>> and cooperated on. Yes, discussion has quieted down and I'm to blame. >>> My apologies to Pat Donlin at SGI. >>> Only request that has been made towards you, resp. Dell, was to change >>> 'setpolicy' to 'policy set' which makes much more sense. As far as I'm >>> aware, this was the only condition for the patch to be accepted and >>> merged in. If you've interpreted any of it as a >>> dependency/prerequisite, then I'm sorry. >>> >> >> Ah well that makes things much easier! Would something like ipmitool pef >> policy and ipmitool pef policy be OK? >> > > You mean to tell me the whole code review was for nothing? That you've > deliberately wasted my time? And now you're asking me to do yet > another code review? Well, good luck with that! > > Z.
Don't be an ass. This is the original patch that I posted in 2013 and have been trying to get upstream so that we can implement additional features. Several weeks of my time was was wasted developing that PEF rework patch due to your unclear instructions. --jordan hargrave Sr. Software Engineer Dell Enterprise Linux Engineering ------------------------------------------------------------------------------ Monitor Your Dynamic Infrastructure at Any Scale With Datadog! Get real-time metrics from all of your servers, apps and tools in one place. SourceForge users - Click here to start your Free Trial of Datadog now! http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140 _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel