Here are my comments about draft-ietf-ipngwg-rfc2553bis-06.txt On many pages, null (the C null pointer constant) is sometimes written as null and sometimes NULL. Also, the ASCII NUL terminated C strings have different written forms. Currently the text has at least these variants of null/NULL:
o NULL pointer o NULL o null pointer o null terminated name o null-terminated string o null byte o null For clarity, maybe all C null pointers could be written as "NULL". When ASCII NUL byte terminated C strings are discussed, they could all be written as "null-terminated string(s)". On top of page 12, there is one instance of _SS_ALIGNMENT. This, I suppose, should be _SS_ALIGNSIZE. Also on page 12, in the example about struct sockaddr_storage on systems with "sa_len", "#define _SS_PAD2SIZE" does not include sizeof (uint8_t), the size of "ss_len" member. On page 18, the printf seems to lack at least \n" and possibly more. On page 19, the second paragraph from bottom, inet_ntop() is used as an example of a function using standard IPv6 text forms. Should this be inet_pton() since it, just like getaddrinfo, takes in character strings (page 26, first paragraph)? On page 22, it is said that freeaddrinfo() frees addrinfo lists with "any additional storage associated with those structures". I take this additional storage is memory pointed by ai_addr and ai_canonname (unless ai_canonname points to the same place as nodename parameter)? Maybe the wording could be made explicit that after freeaddrinfo() is called, the caller MUST not refer to memory pointed by ai_addr members of freed addrinfo structures. The same applies to ai_cannoname if ai_canonname did not point to nodename. -- Heikki Vatiainen * [EMAIL PROTECTED] Tampere University of Technology * Tampere, Finland -------------------------------------------------------------------- IETF IPng Working Group Mailing List IPng Home Page: http://playground.sun.com/ipng FTP archive: ftp://playground.sun.com/pub/ipng Direct all administrative requests to [EMAIL PROTECTED] --------------------------------------------------------------------
