Daniel Kreling <[email protected]> writes:
> This patch adds verbosity to the dump command when it is run on a system that
> does not have IPR adapters attached.
thanks for the catch.
I'm taking that this one and the rest of the set are not related,
right? If this is the case, I suggest splitting them in two threads.
Also, if this is the first time the patch appeared in this list, start
version numbering with 1 for the whole series :)
I'll give the rest of the set a more thorough review later, but this one
seems good to me, provided a small nit is fixed (sorry, only saw it now).
Keep them coming! :)
> --- a/iprconfig.c
> +++ b/iprconfig.c
> @@ -18285,8 +18285,10 @@ static int dump (char **args, int num_args)
> struct ipr_ioa *ioa;
> struct ipr_dev *dev;
>
> - if (!ipr_ioa_head)
> + if (!ipr_ioa_head) {
> + printf("There are no IPR adapters in the system. No dump
> collected...\n");
> return 0;
Error message should go to stderr. Also, we might consider returning an
error code instead of zero, though I'm not sure what are the effect of
this on the caller.
--
Gabriel Krisman Bertazi
------------------------------------------------------------------------------
_______________________________________________
Iprdd-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
