Hi Gabriel,
A couple of comments below.
Thanks,
Brian
On 07/29/2015 02:56 PM, Gabriel Krisman Bertazi wrote:
> --- a/iprconfig.h
> +++ b/iprconfig.h
> @@ -135,6 +135,7 @@ int disk_config(i_container * i_con);
> int ioa_config(i_container * i_con);
> int change_disk_config(i_container *);
> int change_ioa_config(i_container *);
> +int ucode_screen(i_container *i_con);
> int download_ucode(i_container *);
> int choose_ucode(i_container *);
> int log_menu(i_container *);
> @@ -194,7 +195,7 @@ struct screen_opts main_menu_opt[] = {
> {driver_config, "5", __("Work with driver configuration")},
> {disk_config, "6", __("Work with disk configuration")},
> {ioa_config, "7", __("Work with adapter configuration")},
> - {download_ucode, "8", __("Download microcode")},
> + {ucode_screen, "8", __("Work with Microcode updates")},
Let's get rid of that capital Mand make this "Work with microcode updates"
> {log_menu, "9", __("Analyze log")},
> };
>
> @@ -1556,6 +1557,19 @@ s_node n_confirm_set_default_editor = {
> "" }
> };
>
> +
> +struct screen_opts ucode_screen_opt[] = {
> + {download_ucode, "1", __("Download microcode")},
> +};
> +
> +s_node n_ucode_screen = {
> + .rc_flags = (EXIT_FLAG | CANCEL_FLAG | REFRESH_FLAG),
> + .f_flags = (EXIT_FLAG | CANCEL_FLAG),
> + .num_opts = NUM_OPTS(ucode_screen_opt),
> + .options = &ucode_screen_opt[0],
> + .title = __("Work with microcode update")
Let's pluralize that to be "Work with microcode updates" to be consistent
with the menu name we just selected.
> +};
> +
> const char *screen_status[] = {
> /* 0 */ "",
> /* 1 */ "",
>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
------------------------------------------------------------------------------
_______________________________________________
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
