On 11/16/2015 07:00 AM, Gabriel Krisman Bertazi wrote: > @@ -11242,14 +11242,21 @@ int change_ioa_config(i_container * i_con) > i_con = add_i_con(i_con, pref_str, &ioa_config_attr[index++]); > } > if (dev->ioa->has_cache) { > - body = add_line_to_body(body,_("IOA Caching Mode"), "%13"); > - ioa_config_attr[index].option = 4; > - ioa_config_attr[index].caching = ioa_attr.caching; > - if (ioa_attr.caching == IPR_IOA_REQUESTED_CACHING_DEFAULT) > - sprintf(pref_str, "Default"); > - else > - sprintf(pref_str, "Disabled"); > - i_con = add_i_con(i_con, pref_str, &ioa_config_attr[index++]); > + if (dev->ioa->vset_write_cache) { > + body = add_line_to_body(body,_("IOA Caching Mode"), > + "Synchronize Cache"); > + } else {
Since this screen is not a status screen but rather a screen for displaying attributes that can be changed, I'm thinking we should only display the IOA Caching Mode attribute if !dev->ioa->vset_write_cache. > + ioa_config_attr[index].option = 4; > + ioa_config_attr[index].caching = ioa_attr.caching; > + > + if (ioa_attr.caching == > IPR_IOA_REQUESTED_CACHING_DEFAULT) > + sprintf(pref_str, "Default"); > + else > + sprintf(pref_str, "Disabled"); > + i_con = add_i_con(i_con, pref_str, > + &ioa_config_attr[index++]); > + body = add_line_to_body(body,_("IOA Caching Mode"), > "%18"); > + } > } > if (dev->ioa->configure_rebuild_verify) { > body = add_line_to_body(body, > -- Brian King Power Linux I/O IBM Linux Technology Center ------------------------------------------------------------------------------ Presto, an open source distributed SQL query engine for big data, initially developed by Facebook, enables you to easily query your data on Hadoop in a more interactive manner. Teradata is also now providing full enterprise support for Presto. Download a free open source copy now. http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140 _______________________________________________ Iprdd-devel mailing list Iprdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/iprdd-devel