Heitor,
I made the changes below while pulling in the patch.
Thanks,
Brian
On 11/23/2015 07:05 AM, Heitor Ricardo Alves de Siqueira wrote:
> +
> +static const struct {
> + const u8 op;
> + const char *name;
> +} scsi_cmnds[] = {
> + { 0xc1, "IPR_CANCEL_REQUEST" },
Looks like you have a bunch of definitions in this array that are not op codes
and should be removed from this table so they don't conflict with the actual
op codes. The one below is the first one
> + { 0x01, "IPR_CANCEL_64BIT_IOARCB" },
> + { 0xc2, "IPR_QUERY_RSRC_STATE" },
> + { 0xc3, "IPR_RESET_DEVICE" },
And this bunch below
> + { 0x80, "IPR_RESET_TYPE_SELECT" },
> + { 0x40, "IPR_LUN_RESET" },
> + { 0x20, "IPR_TARGET_RESET" },
> + { 0x10, "IPR_BUS_RESET" },
> + { 0x80, "IPR_ATA_PHY_RESET" },
> + { 0xc4, "IPR_ID_HOST_RR_Q" },
> + { 0xc5, "IPR_QUERY_IOA_CONFIG" },
> + { 0xce, "IPR_CANCEL_ALL_REQUESTS" },
> + { 0xcf, "IPR_HOST_CONTROLLED_ASYNC" },
And this bunch below
> + { 0x01, "IPR_HCAM_CDB_OP_CODE_CONFIG_CHANGE" },
> + { 0x02, "IPR_HCAM_CDB_OP_CODE_LOG_DATA" },
> + { 0xfb, "IPR_SET_SUPPORTED_DEVICES" },
And this one below
> + { 0x80, "IPR_SET_ALL_SUPPORTED_DEVICES" },
> + { 0xf7, "IPR_IOA_SHUTDOWN" },
And this one below
> + { 0x05, "IPR_WR_BUF_DOWNLOAD_AND_SAVE" },
> +
> + { 0x00, "TEST_UNIT_READY" },
> + { 0x01, "REZERO_UNIT" },
> + { 0x03, "REQUEST_SENSE" },
> + { 0x04, "FORMAT_UNIT" },
> + { 0x05, "READ_BLOCK_LIMITS" },
> + { 0x07, "REASSIGN_BLOCKS" },
> +/**
> + * print_dump_header -
> + * @hdr: ipr dump header pointer
> + *
> + * Returns:
> + * nothing
> + **/
> +static void print_dump_header(struct ipr_dump_header *hdr)
> +{
> + fprintf(out_fp, "IPR Adapter Dump Report\n\n");
> + switch (hdr->eye_catcher) {
> + case EYE_CATCHER_BE:
> + fprintf(out_fp, "Big Endian format: ");
> + break;
> + case EYE_CATCHER_LE:
> + fprintf(out_fp, "Little Endian format: ");
> + break;
> + default:
> + fprintf(out_fp, "Unknown dump format: ");
> + }
> + fprintf(out_fp, "Eye Catcher is 0x%08X\n", hdr->eye_catcher);
> +
> + fprintf(out_fp, "Total length: %d bytes\n", hdr->len);
> + fprintf(out_fp, "Number of dump entries: %d\n", hdr->num_entries);
> + fprintf(out_fp, "Offset to first entry: 0x%08X bytes\n",
> + hdr->first_entry_offset);
> + fprintf(out_fp, "Dump status: 0x%08X ", hdr->status);
> + switch (hdr->status) {
> + case IPR_DUMP_STATUS_SUCCESS:
> + fprintf(out_fp, "(SUCCESS)\n");
> + break;
> + case IPR_DUMP_STATUS_QUAL_SUCCESS:
> + fprintf(out_fp, "(QUAL_SUCCESS)\n");
> + break;
> + case IPR_DUMP_STATUS_FAILED:
> + fprintf(out_fp, "(FAILED)\n");
> + break;
> + default:
> + fprintf(out_fp, "(UNKNOWN)\n");
> + }
> +
> + fprintf(out_fp, "Operating System: ");
> + switch (hdr->os) {
> + case OS_LINUX:
> + fprintf(out_fp, "Linux\n");
> + break;
> + case OS_I5OS:
> + fprintf(out_fp, "i5OS\n");
> + break;
We shouldn't ever see i5OS, so suggest you just remove it from the switch
statement here.
> + default:
> + fprintf(out_fp, "unknown\n");
> + }
> +
> + fprintf(out_fp, "Driver: ");
> + switch (hdr->driver_name) {
> + case DRV_IPR2:
> + fprintf(out_fp, "ipr2\n");
> + break;
> + case DRV_V5R4:
> + fprintf(out_fp, "V5R4\n");
> + break;
Same with the V5R2 string
> + default:
> + fprintf(out_fp, "unknown\n");
> + }
> +}
> +
--
Brian King
Power Linux I/O
IBM Linux Technology Center
------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
_______________________________________________
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
