Brian King <brk...@linux.vnet.ibm.com> writes:
>> +int device_stats(i_container *i_con)
>> +{
>> + int rc;
>> + struct ipr_dev *dev;
>> + char *body = NULL;
>> + char *tmp;
>> + s_node *n_screen = &n_device_stats;
>> + struct screen_output *s_out;
>> +
>> + processing();
>> + if ((rc = device_details_get_device(i_con, &dev)))
>> + return rc;
>> +
>> + if (ipr_is_af_dasd_device(dev)) {
>> + body = af_dasd_perf(body, dev);
>> + }
>> +
>> + body = print_ssd_report(dev, body);
>
> This looks to be broken for HDDs since print_ssd_report returns NULL here.
>
> Also, I'd suggest we display the ssd_report data before the af_dasd_perf data,
> since it seems like that might be more interesting to people.
That one was nasty. Sorry. Already fixed that.
Can you think of any statistics that would be interesting to display for
generic JBOD disks? For JBOD SSDs, at least, we display ssd_report, but
for JBOD HDDs we don't show anything yet.
Any suggestions?
--
Gabriel Krisman Bertazi
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
