On 01/06/2016 09:43 AM, Gabriel Krisman Bertazi wrote:
> A bug in TUI prevents users from configuring Asymmetrict Access
> optimizations for RAID devices. This happens because screen_driver
> doesn't return RC_SUCCESS when exiting the option menu. This patch
> makes sure the configuration is written to the adapter if the user
> modified it.
>
> Signed-off-by: Gabriel Krisman Bertazi <kris...@linux.vnet.ibm.com>
> ---
> iprconfig.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/iprconfig.c b/iprconfig.c
> index fadf562..b2ebbef 100644
> --- a/iprconfig.c
> +++ b/iprconfig.c
> @@ -5628,12 +5628,14 @@ int configure_asym_access(struct array_cmd_data *acd)
> rc = s_out->rc;
> free(s_out);
>
> - if (rc == RC_SUCCESS) {
> + if (rc == CANCEL_FLAG)
> + goto leave;
> +
> + if (rc == EXIT_FLAG || rc == RC_SUCCESS) {
This doesn't look quite right. The way the user interface is supposed to work
is 'q'=Cancel aborts your changes and kicks you back to the list of devices.
Selecting 'e'=Exit is supposed to abort your changes and the current task and
kick you back to the last menu. To actually change the setting, you type 'c' to
get the pull down, use the arrow keys to select what you want and type Enter.
Then
type Enter again to commit the change.
When I looked on a system, if I hit the Enter key it seems like it does change
the setting.
If I go back in to change it again, the currently displayed value is the one I
set it to.
Is this simply a user error of someone hitting 'e' rather than Enter to set the
value?
As I was looking at the code, I see that we don't seem to persist the
asymmetric state
for each array in a config file anywhere. This seems like an issue we may need
to fix.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
