iprconfig man page requires an IOA to be passed to query-raid-create and
query-raid-delete. Right now, iprconfig doesn't enforce it, allowing
disk devices to be passed as parameters, which is confusing. I found
that when playing with raid initialization code. Let's fix it.
Signed-off-by: Gabriel Krisman Bertazi <kris...@linux.vnet.ibm.com>
---
iprconfig.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/iprconfig.c b/iprconfig.c
index 9d0942d..c92d50e 100644
--- a/iprconfig.c
+++ b/iprconfig.c
@@ -14420,6 +14420,11 @@ static int query_raid_create(char **args, int num_args)
return -EINVAL;
}
+ if (&dev->ioa->ioa != dev) {
+ fprintf(stderr, "Device is not an IOA\n");
+ return -EINVAL;
+ }
+
ioa = dev->ioa;
if (!ioa->qac_data->num_records)
@@ -14463,6 +14468,11 @@ static int query_raid_delete(char **args, int num_args)
return -EINVAL;
}
+ if (&dev->ioa->ioa != dev) {
+ fprintf(stderr, "Device is not an IOA\n");
+ return -EINVAL;
+ }
+
ioa = dev->ioa;
for_each_vset(ioa, dev) {
--
2.1.0
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
