Hi Gabriel,
This doesn't apply cleanly. Can you rebase the patch? Also, a couple of
minor comments below.
Thanks,
Brian
On 03/28/2016 12:15 PM, Gabriel Krisman Bertazi wrote:
> diff --git a/iprconfig.c b/iprconfig.c
> index 3189af0..3262816 100644
> --- a/iprconfig.c
> +++ b/iprconfig.c
> @@ -3665,6 +3665,7 @@ int configure_raid_parameters(i_container *i_con)
> }
> }
>
> + max_qdepth = ipr_max_queue_depth(ioa, selected_count, ssd_num);
> if (ioa->sis64)
> qdepth = selected_count * 16;
> else
> @@ -3783,7 +3784,7 @@ int configure_raid_parameters(i_container *i_con)
> mvaddstr(6, 1, _("c=Change Setting"));
> mvaddstr(8, 0, "Protection Level . . . . . . . . . . . . :");
> mvaddstr(9, 0, "Stripe Size . . . . . . . . . . . . . . :");
> - mvprintw(10, 0, "Queue Depth (default = %3d). . . . . . . :", qdepth);
> + mvprintw(10, 0, "Queue Depth (default = %3d)(max = %3d) . :", qdepth);
Aren't you missing a parameter here for the max queue depth?
> if (ioa->vset_write_cache)
> mvprintw(11, 0, "Array Write Cache Policy . . . . . . . . :");
> mvaddstr(max_y - 4, 0, _("Press Enter to Continue"));
> diff --git a/iprlib.c b/iprlib.c
> index a899e1b..1e1d524 100644
> --- a/iprlib.c
> +++ b/iprlib.c
> @@ -2101,6 +2101,7 @@ static int __tool_init(int save_state)
> DIR *dirfd, *host_dirfd;
> struct dirent *dent, *host_dent;
> ssize_t len;
> + char queue_str[256];
>
> save_old_config();
>
> @@ -2158,7 +2159,12 @@ static int __tool_init(int save_state)
> sscanf(fw_str, "%d", &fw_type);
> if (ipr_debug)
> syslog(LOG_INFO, "tool_init: fw_type attr =
> %d.\n", fw_type);
> - break;
> +
> + len = sysfs_read_attr(scsipath, "can_queue", queue_str,
> 256);
> + if (len < 0)
> + ioa_dbg(ipr_ioa, "Failed to read can_queue
> attribute");
> + sscanf(queue_str, "%d", &ipr_ioa->can_queue);
> + break;
Indentation issue with this break.
> }
> closedir(host_dirfd);
> if (ipr_ioa->host_num < 0) {
> @@ -6943,6 +6949,8 @@ static void ipr_save_dev_attr(struct ipr_dev *dev, char
> *field,
> char *value, int update)
> {
> char category[100];
> + struct ipr_dev *alt_dev = dev->alt_path;
> +
> if (dev->scsi_dev_data->device_id)
> sprintf(category,"[%s %lx]", IPR_CATEGORY_DEVICE,
> dev->scsi_dev_data->device_id);
--
Brian King
Power Linux I/O
IBM Linux Technology Center
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140
_______________________________________________
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
