On 07/11/2016 10:41 AM, Wen Xiong wrote: > Hi Brian, > > I set it by default. There are two reasons: > - The latest upstream kernel and kernels in linux distros didn't enable MQ by > default. Need to rebuild the kernel if want to use MQ feature. > - Didn't have time to test performance yet this year(Will try to find system > to test this when powerio-blue system is up today).
Let's submit what we have so we can get this series into the next merge window. Once we have more runtime with mq we can submit a follow on patch to enable by default. Thanks, Brian > > Thanks, > Wendy > > Inactive hide details for Brian King ---07/06/2016 09:34:11 AM---On > 07/05/2016 12:44 PM, [email protected] wrote: > FBrian King > ---07/06/2016 09:34:11 AM---On 07/05/2016 12:44 PM, > [email protected] wrote: > From: Wen Xiong <[email protected] > > From: Brian King <[email protected]> > To: [email protected], [email protected] > Date: 07/06/2016 09:34 AM > Subject: Re: [Iprdd-devel] [PATCH 3/3] ipr: Add scsi multi-queue support > > ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- -- > > > > On 07/05/2016 12:44 PM, [email protected] wrote: >> From: Wen Xiong <[email protected]> >> >> Add scsi multi-queue support in ipr driver. This feature >> is enabled by setting ipr_use_blk_mq=1 when loading ipr >> module and scsi blk-mq is enabled in the kernel. >> >> Signed-off-by: Wen Xiong <[email protected]> >> --- >> drivers/scsi/ipr.c | 16 ++++++++++++++-- >> drivers/scsi/ipr.h | 1 + >> 2 files changed, 15 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c >> index 1f539c2..21b6da6 100644 >> --- a/drivers/scsi/ipr.c >> +++ b/drivers/scsi/ipr.c >> @@ -100,6 +100,7 @@ static unsigned int ipr_max_devs = >> IPR_DEFAULT_SIS64_DEVS; >> static unsigned int ipr_dual_ioa_raid = 1; >> static unsigned int ipr_number_of_msix = 16; >> static unsigned int ipr_fast_reboot; >> +static unsigned int ipr_use_blk_mq = 0; > > Why do we disable this by default? > > Thanks, > > Brian > > > -- > Brian King > Power Linux I/O > IBM Linux Technology Center > > > ------------------------------------------------------------------------------ > Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San > Francisco, CA to explore cutting-edge tech and listen to tech luminaries > present their vision of the future. This family event has something for > everyone, including kids. Get more information and register today. > http://sdm.link/attshape > _______________________________________________ > Iprdd-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/iprdd-devel > > > -- Brian King Power Linux I/O IBM Linux Technology Center ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Iprdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/iprdd-devel
