If an IOA is missing its scsi_dev_data, we want to skip it and look for
other IOAs, instead of bailing out early.
This also fixes the compilation warning below:
../iprconfig.c: In function ‘update_all_ucodes’:
../iprconfig.c:15735:4: warning: ‘return’ with no value, in function returning
non-void
return;
^~~~~~
../iprconfig.c:15725:12: note: declared here
static int update_all_ucodes(char **args, int num_args)
^~~~~~~~~~~~~~~~~
Signed-off-by: Gabriel Krisman Bertazi <kris...@linux.vnet.ibm.com>
---
iprconfig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/iprconfig.c b/iprconfig.c
index 9bd2122791a2..0d78a558f4b1 100644
--- a/iprconfig.c
+++ b/iprconfig.c
@@ -15732,7 +15732,7 @@ static int update_all_ucodes(char **args, int num_args)
for_each_ioa(ioa) {
if (!ioa->ioa.scsi_dev_data)
- return;
+ continue;
for_each_dev(ioa, dev) {
if (ipr_is_volume_set(dev))
continue;
--
2.7.4
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
