On Monday 04 Apr 2011 19:06:31 Dylan's PCs wrote:
> Good reasons all. But MyBB doesn't need Apache to restart or any of
> that, which is why I wondered.
> I didn't think about the security audits and such though, its a good
> point. Hopefully you'll never need to downgrade ;)

Having an RPM also makes it easy to keep track of the bugfix patches (both 
attached for reference in case you're interested - one fixes some invalid SQL 
that gets rejected by PostgreSQL, the other adjusts some filesystem permissions 
that cause the security audit to complain about world-writeable files).


The forum has been running happily at http://forum.ipxe.org for several days 
now, and is up to 8 members and 26 posts.  I'm really quite pleased with it!

Michael
diff --git a/Upload/forumdisplay.php b/Upload/forumdisplay.php
index 86edb82..6e1c1de 100644
--- a/Upload/forumdisplay.php
+++ b/Upload/forumdisplay.php
@@ -706,7 +706,6 @@ if($fpermissions['canviewthreads'] != 0)
 		LEFT JOIN ".TABLE_PREFIX."users u ON (u.uid = t.uid){$select_voting}
 		LEFT JOIN ".TABLE_PREFIX."threadprefixes p ON (p.pid = t.prefix)
 		WHERE t.fid='$fid' $tuseronly $tvisibleonly $datecutsql2
-		GROUP BY t.tid
 		ORDER BY t.sticky DESC, {$t}{$sortfield} $sortordernow $sortfield2
 		LIMIT $start, $perpage
 	");
diff --git a/Upload/inc/functions_image.php b/Upload/inc/functions_image.php
index 4152993..f4adbce 100644
--- a/Upload/inc/functions_image.php
+++ b/Upload/inc/functions_image.php
@@ -141,7 +141,7 @@ function generate_thumbnail($file, $path, $filename, $maxheight, $maxwidth)
 				@imagepng($thumbim, $path."/".$filename);
 				break;
 		}
-		@my_chmod($path."/".$filename, '0666');
+		@my_chmod($path."/".$filename, '0644');
 		@imagedestroy($thumbim);
 		$thumb['code'] = 1;
 		$thumb['filename'] = $filename;
_______________________________________________
ipxe-devel mailing list
[email protected]
https://lists.ipxe.org/mailman/listinfo/ipxe-devel

Reply via email to