On Wed, 2013-05-15 at 15:56 +0100, Michael Brown wrote: > On 13/05/13 15:59, Frediano Ziglio wrote: > > From 1827c48034d2387819629c4b28d7c2910b5d889b Mon Sep 17 00:00:00 2001 > > From: Frediano Ziglio<[email protected]> > > Date: Mon, 13 May 2013 15:58:32 +0100 > > Subject: [PATCH] Fix loading tftp file from pxe bios call > > > > If filename contained '#' tftp does not load correctly file cause url was > > not > > quoted correctly. > > > > This patch actually fix two paths in the code that require quoting filename: > > - loading file from dhcp; > > - loading file from PXE calls. > > The fact that TFTP doesn't fit neatly into the RFC2396's concept of a > URI is extremely annoying! > > Would it be neater to have net/udp/tftp.c append "#" and uri->fragment > if uri->fragment is non-NULL? This would then provide the same > behaviour for TFTP URIs present in scripts. > > Michael
I don't know. The file name was something like "test#123" and on wireshark a "test" file was requested. I have a small test environment (which use Qemu, dnsmasq and some binary files) which try to use such strange names. Does iPXE have some automatic tests so I can add mine too? Frediano _______________________________________________ ipxe-devel mailing list [email protected] https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
