Any comment on this driver please... -----Original Message----- From: ipxe-devel-boun...@lists.ipxe.org [mailto:ipxe-devel-boun...@lists.ipxe.org] On Behalf Of Ravi Hegde - C21689 Sent: Wednesday, March 23, 2016 4:10 PM To: mc...@ipxe.org; ipxe-de...@ipxe.org Subject: Re: [ipxe-devel] [PATCH 0/2] lan78xx: Adding Microchip lan78xx driver support
> Are the devices similar enough that it would make sense to extend the > smsc75xx driver to cover both? It has somewhat similar MAC. Phy is different(driver may not do anything differently). Has OTP. I thought it would clutter the smsc75xx code if I try to combine. Thanks Ravi -----Original Message----- From: Michael Brown [mailto:mc...@ipxe.org] Sent: Wednesday, March 23, 2016 3:52 PM To: Ravi Hegde - C21689; ipxe-de...@ipxe.org Subject: Re: [ipxe-devel] [PATCH 0/2] lan78xx: Adding Microchip lan78xx driver support On 23/03/16 19:01, ravi.he...@microchip.com wrote: > Adding support for Microchip lan78xx USB 3.0 to Ethernet device. > > Maintained code structure of old smsc/microchip smsc75xx driver. Thank you! After several years of seeing dubiously licensed Microchip ROMs (which were very obviously built from gPXE/iPXE code without attribution or GPL compliance), it's a pleasure to see some source contributions coming from Microchip. The driver appears to be largely identical to the existing smsc75xx driver. I haven't checked the full set of differences, but at least the TX and RX datapath seem to use identical data structures and register values. Are the devices similar enough that it would make sense to extend the smsc75xx driver to cover both? Thanks, Michael _______________________________________________ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel _______________________________________________ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
