Hi, I'm sorry for the late response, and awkward reply style: I subscribed after having got response to the patch, so I didn't have the reference-id of the mail to respond to.
I'll respond to the comment nevertheless. On Sat, 10 Sep 2016 23:03:40 +0200 Denis 'GNUtoo' Carikli <gnu...@no-log.org> wrote: > $(BIN)/%.tmp : $(BIN)/version.%.o $(BLIB) $(MAKEDEPS) $(LDSCRIPT) [...] > + --defsym _build_id=0x`cat $? | sha1sum | cut -c-8` \ Using $? is indeed a mistake: According to GNU make manual[1], "The names of all the prerequisites that are newer than the target, with spaces between them. For prerequisites which are archive members, only the named member is used (see Archives)." This will create issues when some of the prerequisites have already been build. Using $^ fixes it. I will resend a patch with $^ instead. I've also tested if $^ is affected by concurrency and it doesn't seem to. I've attached the test case, and here's the output on my machine with GNU Make 4.2.1: % ./test.sh -j 9999 out reference differ: byte 14, line 3 Inversion(s) happened OK References: ----------- [1]https://www.gnu.org/software/make/manual/make.html#Automatic-Variables Denis.
all: target target: dep1 dep2 dep3 dep4 dep5 dep6 dep7 dep8 dep9 dep10 dep11 dep12 dep13 dep14 dep15 dep16 dep17 dep18 dep19 dep20 dep21 dep22 dep23 dep24 dep25 dep26 dep27 dep28 dep29 dep30 dep31 dep32 dep33 dep34 dep35 dep36 dep37 dep38 dep39 dep40 dep41 dep42 dep43 dep44 dep45 dep46 dep47 dep48 dep49 dep50 dep51 dep52 dep53 dep54 dep55 dep56 dep57 dep58 dep59 dep60 dep61 dep62 dep63 dep64 dep65 dep66 dep67 dep68 dep69 dep70 dep71 dep72 dep73 dep74 dep75 dep76 dep77 dep78 dep79 dep80 dep81 dep82 dep83 dep84 dep85 dep86 dep87 dep88 dep89 dep90 dep91 dep92 dep93 dep94 dep95 dep96 dep97 dep98 dep99 dep100 @echo $^ dep1: @echo $@ dep2: @echo $@ dep3: @echo $@ dep4: @echo $@ dep5: @echo $@ dep6: @echo $@ dep7: @echo $@ dep8: @echo $@ dep9: @echo $@ dep10: @echo $@ dep11: @echo $@ dep12: @echo $@ dep13: @echo $@ dep14: @echo $@ dep15: @echo $@ dep16: @echo $@ dep17: @echo $@ dep18: @echo $@ dep19: @echo $@ dep20: @echo $@ dep21: @echo $@ dep22: @echo $@ dep23: @echo $@ dep24: @echo $@ dep25: @echo $@ dep26: @echo $@ dep27: @echo $@ dep28: @echo $@ dep29: @echo $@ dep30: @echo $@ dep31: @echo $@ dep32: @echo $@ dep33: @echo $@ dep34: @echo $@ dep35: @echo $@ dep36: @echo $@ dep37: @echo $@ dep38: @echo $@ dep39: @echo $@ dep40: @echo $@ dep41: @echo $@ dep42: @echo $@ dep43: @echo $@ dep44: @echo $@ dep45: @echo $@ dep46: @echo $@ dep47: @echo $@ dep48: @echo $@ dep49: @echo $@ dep50: @echo $@ dep51: @echo $@ dep52: @echo $@ dep53: @echo $@ dep54: @echo $@ dep55: @echo $@ dep56: @echo $@ dep57: @echo $@ dep58: @echo $@ dep59: @echo $@ dep60: @echo $@ dep61: @echo $@ dep62: @echo $@ dep63: @echo $@ dep64: @echo $@ dep65: @echo $@ dep66: @echo $@ dep67: @echo $@ dep68: @echo $@ dep69: @echo $@ dep70: @echo $@ dep71: @echo $@ dep72: @echo $@ dep73: @echo $@ dep74: @echo $@ dep75: @echo $@ dep76: @echo $@ dep77: @echo $@ dep78: @echo $@ dep79: @echo $@ dep80: @echo $@ dep81: @echo $@ dep82: @echo $@ dep83: @echo $@ dep84: @echo $@ dep85: @echo $@ dep86: @echo $@ dep87: @echo $@ dep88: @echo $@ dep89: @echo $@ dep90: @echo $@ dep91: @echo $@ dep92: @echo $@ dep93: @echo $@ dep94: @echo $@ dep95: @echo $@ dep96: @echo $@ dep97: @echo $@ dep98: @echo $@ dep99: @echo $@ dep100: @echo $@
reference
Description: Binary data
test.sh
Description: application/shellscript
pgpyXIITanvMn.pgp
Description: OpenPGP digital signature
_______________________________________________ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
