HI Michael,
Thanks for reviewing my commit :)
1. It doesn't solve any problem, but I see 2 purposes. First, if a table is
corrupted we shouldn't use the table (that may prevent big problems). Second,
(and why I implemented the check) when manipulating ACPI tables it's good to
know that the tables are 'probably' not corrupted. For example, I'm working
with MADT in ipxe, but I had to debug. So first thing I did was checking the
checksum.
2. Debug message fixed.
3. Nice, I didn't think the compiler would optimize the copy_from_user() calls.
Done
3a. Good idea, so it's done
Thanks,
Laurent
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/65#issuecomment-318678324
_______________________________________________
ipxe-devel mailing list
[email protected]
https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel