> > Note that there's also 
> > https://github.com/chschenk/ipxe/tree/feature/tls_fragmentation_buildoption 
> > which add's a build option. By making this code optional and disable that 
> > build option by default it at least wouldn't break anything. Regarding 
> > security concerns: granted. But we're talking about ~50 lines of code here.
> 
> To that, please see https://dox.ipxe.org/ifdef_harmful.html You can introduce 
> huge security issues with only one line of code.

I wasn't suggesting that you can't. I was trying to say that it's "only" 50 
lines of code to review.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/116#issuecomment-1096777453
You are receiving this because you commented.

Message ID: <ipxe/ipxe/pull/116/c1096777...@github.com>
_______________________________________________
ipxe-devel mailing list
ipxe-devel@lists.ipxe.org
https://lists.ipxe.org/mailman/listinfo/ipxe-devel

Reply via email to