Tomas has already fixed that here :(. As you might imagine, our desire to astound and amaze the audience at RailsConf has led to some shortcuts getting taken with respect to the code reviews going out to this list. This will certainly not be the case post-conference once we start fixing the "community" part of this "community project".
Disclaimer: by "astound and amaze" I mean "keep from getting laughed out of the room". -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Peter Bacon Darwin Sent: Thursday, May 29, 2008 1:22 PM To: [email protected] Subject: Re: [Ironruby-core] Code Review: FastFixes1 This bit doesn't work: + [RubyModule(Extends = typeof(Kernel))] + public static class KernelOps { + [RubyMethod("BigDecimal", RubyMethodAttributes.PrivateInstance)] + [RubyMethod("BigDecimal", RubyMethodAttributes.PublicSingleton)] + public static object CreateBigDecimal(CodeContext/*!*/ context, object self, [NotNull]MutableString/*!*/ value) { + return BigDecimalOps.Create(context, value); + } + + [RubyMethod("BigDecimal", RubyMethodAttributes.PrivateInstance)] + [RubyMethod("BigDecimal", RubyMethodAttributes.PublicSingleton)] + public static object CreateBigDecimal(CodeContext/*!*/ context, object self, object value) { + return BigDecimalOps.Create(context, value); + } + } +} The initializer code builds up the methods nicely but the "Kernel" module is not in RubyExecutionContext._moduleCache, so the methods don't get added to Kernel (but instead added to a Module called Ruby::Builtins::Kernel. Any help here? Cheers, Pete -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of John Lam (IRONRUBY) Sent: Wednesday,28 May 28, 2008 17:04 To: Curt Hagenlocher; IronRuby External Code Reviewers Cc: [email protected] Subject: Re: [Ironruby-core] Code Review: FastFixes1 Missing a few method return bangs in BigDecimalOps.cs I guess you're going to implement Kernel#BigDecimal eventually ... Otherwise looks good! Thanks, -John -----Original Message----- From: Curt Hagenlocher Sent: Wednesday, May 28, 2008 8:43 AM To: IronRuby External Code Reviewers Cc: [email protected] Subject: Code Review: FastFixes1 tfpt review "/shelveset:FastFixes1;REDMOND\curth" Fixed critical error in Dir.glob Added File.split Added stub for BigDecimal class -- Curt Hagenlocher [EMAIL PROTECTED] _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
