Looks good. Tomas
-----Original Message----- From: Oleg Tkachenko Sent: Friday, June 20, 2008 8:44 AM To: IronRuby External Code Reviewers Cc: [email protected] Subject: Code Review: YamlDump tfpt review "/shelveset:YamlDump;REDMOND\olegtk" Comment : Fixes Object.to_yaml by making it nondynamic call. Improves dump implementation by overriding taguri method on hash, array, string, number and symbol. Fixes dumping to a file (newlines were going nowhere). Fixes emitter so it doesn't emit empty line before first document. Adds more unit tests. -- Oleg _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
