Looks good. -----Original Message----- From: Oleg Tkachenko Sent: Tuesday, June 24, 2008 10:24 AM To: IronRuby External Code Reviewers Cc: [email protected] Subject: Code Review: YamlSymbolAndTags
tfpt review "/shelveset:YamlSymbolAndTags;REDMOND\olegtk" Comment : Implements loading symbols - non empty string (len > 1) starting with ':' is loaded as symbol, not as string. Implements YAML::tagged_classes hash, fills it with default tags. Imlements YAML::tag_class method. Closes file when loading yaml document from a file. Fixes YAML::tagurize method. Still not fully compatible with MRI, but at least compatible with JRuby. Adds more unit tests. -- Oleg _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
