Understood. We do need to watch for a littered namespace though if we are going to keep stuff top level. That's part of why Rails moved to namespaces. What's your thought on splitting the Rakefile into a compile.rake and a test.rake, for easier maintenance?
JD ________________________________________ From: John Lam (IRONRUBY) Sent: Thursday, June 26, 2008 8:15 PM To: Jim Deville; [email protected]; IronRuby External Code Reviewers Subject: RE: Code Review: mspec-12 Jim Deville: > Test issues: > * Instead of testing for ENV["HOME"] with > unless ENV["HOME"].nil? > why not use > if ENV["HOME"] > it's a little more idiomatic. Done. > * All of the _spec.rb.txt files have been renamed to _tags.txt. You'll > need to fix your changeset for that. Done. > * The new rakefile doesn't allow testing methods directly. Any reason? > Also, I'd prefer to keep the test tasks namespaced for organization > sake. Can you at least move them into the mspec namespace with the rest > of the mspec tasks? I'll remove redundant tasks later. It's done to keep typing to a minimum. I don't like having to type more than I have to (and rake regression is already quite long). I replaced rake test to keep things short as well. I realize that folks can define aliases for these, but I'd rather the out of box experience be better than that. Thanks, -John _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
