I know that at some point, we were always defining multiple overloads in cases like this. For center, I would have probably included both the old signature and the new one:
Center(CodeContext, MutableString, int len, [Optional]MutableString padding); Center(CodeContext, MutableString, object len, [Optional]object pad); ...and simply had the more general version do it's protocol-based conversions and then call the more specific implementation. But I don't know if that's still the convention we're following for the libraries. -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Dave Remy Sent: Saturday, June 28, 2008 2:21 PM To: IronRuby External Code Reviewers Cc: [email protected] Subject: [Ironruby-core] Code Review: MutableStringCenter tfpt review "/shelveset:MutableStringCenter;REDMOND\dremy" Comment : Made changes for MutableString.center to pass specs. Included flowing taint correctly, subclassing, changing signature to use object and then doing manual conversion. _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
