Currently YAML just deserializes bound values (as objects) and passes then to 
the Range constructor.
Do you mean that YAML can check bounds itself before constructing range?

--
Oleg


-----Original Message-----
From: Tomas Matousek
Sent: Friday, June 27, 2008 6:32 PM
To: Oleg Tkachenko; IronRuby External Code Reviewers
Cc: [email protected]
Subject: RE: Code Review: YamlRange

Why not to add Range constructor w/o CodeContext instead? The context is used 
only to compare bounds. Does YAML actually invoke <=> method when constructing 
range?

Tomas

-----Original Message-----
From: Oleg Tkachenko
Sent: Friday, June 27, 2008 5:01 PM
To: IronRuby External Code Reviewers
Cc: [email protected]
Subject: Code Review: YamlRange


tfpt review "/shelveset:YamlRange;REDMOND\olegtk"
Comment  :
  Fixes Range support: implements taguri() and loading Range object from yaml.
  Changes constructors to hold a reference to a code context instead of 
EqualityComparer (Range constructors wants it).

--
Oleg
_______________________________________________
Ironruby-core mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/ironruby-core

Reply via email to