inline Changes commited as: d3d88c3
JD From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Peter Bacon Darwin Sent: Friday, July 11, 2008 12:40 PM To: [email protected] Subject: Re: [Ironruby-core] More spec review Hi Jim, Great stuff. The more I use Git and GitHub the more I love it. I started to write comments, in GitHub, against the commits but then thought better of it. I don't know what happens to them. Sorry if some of these comments are pedantic. Feel free to ignore them. Pete Commit 12308400 - There is a typo in the description of the it "yields while decreaing[sic] self until it less than ceil for a Float endpoint" description fixed - Should you also consider testing downto and upto towards negative floats since Ruby has different semantics for ceil than some other languages? E.g. 3.downto(-1.3) should produce [3, 2, 1, 0, -1] rather than [3,2,1,0,-1,-2]. Good catch. Tests added. Commit fb9a920 - Do you need to remove the constant that is created inside it "should perform top level evaluations from inside a block" to prevent leakage of memory and/or semantic? done Commit cc48d366 - There is a typo in the description of the it "includes the curret[sic] directory" description. - My version of MRI Ruby does not have a RUBY_ENGINE constant. If this is the case does the whole it clause need to be wrapped in a compliant_on() block? - There is a typo in the description of the it "allow substitutionof[sic] literal regexps" description. Typo's fixed. On #rubyspec Brian suggested we leave it as is to add an incentive to MRI. If it bugs you we can do a version guard. From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jim Deville Sent: Friday,11 July 11, 2008 07:17 To: [email protected]; IronRuby External Code Reviewers; Srivatsn Narayanan Subject: [Ironruby-core] More spec review I've commited some more stuff to my Rubyspec fork, I'd like to get some reviews before I merge them to Johns. The commit numbers are: 123084 fb9a920 b7d69ef ddbab38 a2a3c4b cc48d366 That's the last 6 commits I've made. Thanks. ~~~~ JD http://blog.jredville.com
_______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
