There is a "Tests Not in a list" testlist in the vsmdi. Its there because some hosting tests don't belong to any testlist. I'll talk to sesh about cleaning it up but can you remove this manually in the meanwhile (as in using notepad). This screws up SNAP otherwise.
Otherwise it looks good. Go ahead with it after fixing the vsmdi. -----Original Message----- From: Jim Deville Sent: Monday, September 15, 2008 1:03 PM To: [email protected]; Srivatsn Narayanan; IronRuby External Code Reviewers Subject: RE: Code Review: remove_old_spec Fixed, can you recheck for me? Same shelveset JD > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:ironruby-core- > [EMAIL PROTECTED] On Behalf Of Jim Deville > Sent: Monday, September 15, 2008 11:41 AM > To: Srivatsn Narayanan; IronRuby External Code Reviewers > Cc: [email protected] > Subject: Re: [Ironruby-core] Code Review: remove_old_spec > > Any idea why VS decided to check that file out? > > I'm trying to get into the habit of running tfpt uu before shelving, > but I missed it this time. I'll run that and the sortvsmdi script and > resubmit. > > > JD > > > -----Original Message----- > > From: Srivatsn Narayanan > > Sent: Monday, September 15, 2008 11:38 AM > > To: Jim Deville; IronRuby External Code Reviewers > > Cc: [email protected] > > Subject: RE: Code Review: remove_old_spec > > > > Rowantest.vbproj doesn't have any changes. Could you sort the vsmdi > > (using sortvsmdi.py in test\scripts)? There are too many changes > > otherwise. > > > > -----Original Message----- > > From: Jim Deville > > Sent: Monday, September 15, 2008 11:29 AM > > To: IronRuby External Code Reviewers; Srivatsn Narayanan > > Cc: [email protected] > > Subject: Code Review: remove_old_spec > > > > tfpt review "/shelveset:remove_old_spec;REDMOND\jdeville" > > Comment : > > This change removes the old specs from the test directory. It also > > removes the Rake tasks for those tests, and gets them out of SNAP. > > > > _______________________________________________ > Ironruby-core mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/ironruby-core _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
