Both overloads of RubyExceptionData.AddBacktrace take skipFrames as a reference 
parameter, but it doesn't look like any of the call sites care about the 
modified value.  Looks good otherwise.

-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Tomas Matousek
Sent: Tuesday, September 30, 2008 5:27 PM
To: IronRuby External Code Reviewers
Cc: [email protected]
Subject: [Ironruby-core] Code Review: BacktraceFix

tfpt review "/shelveset:BacktraceFix;REDMOND\tomat"
Comment  :
  Backtraces weren't handled correctly for rethrown exceptions.
  Adds some tests for backtraces and modifies the infrastructure to run unit 
tests in all combinations of /interpret and /partial modes.

Tomas
_______________________________________________
Ironruby-core mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/ironruby-core

Reply via email to