Looks good. One minor formatting problem: Some of the changed parts of parser.y are now using tab characters instead of spaces.
In the BlockSignatureAttributes enumeration (in BlockDispatcher.cs), there's a comment that "bits 31..3 store arity". Are you numbering bits from 1? I'm used to numbering them from zero :). -----Original Message----- From: Tomas Matousek Sent: Friday, October 03, 2008 8:57 PM To: IronRuby External Code Reviewers Cc: [email protected] Subject: Code Review: arity tfpt review "/shelveset:arity;REDMOND\tomat" Comment : Fixes bugs in block parameters: 1) Anonymous unsplat parameters were not handled correctly (the parser ignored them): def y a = [1,2,3,4,5] yield a,[6] end y { |(x,y,*),*| p x,y } 2) Arity wasn't calculated correctly. Arity depends upon AST structure that is not preserved in runtime. Therefore we need to calculate block arity at compile time and save it to BlockDispatcher. Some peculiar cases: Proc.new{|(a,b,c,*)|}.arity.should == -4 Proc.new{|(*)|}.arity.should == -1 Proc.new{}.arity.should == -1 Proc.new{||}.arity.should == 0 Proc.new{x,}.arity.should == 1 Proc.new{(x,)}.arity.should == 1 Tomas _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
