tfpt review "/shelveset:raise;REDMOND\sborde"
  Comment  :
  Implements Thread#raise using Thread.Abort, and added tests for it
  Implemented stress mode (RubyOptions.UseThreadAbortForSyncRaise) which found 
more issues. Fixed most but not all
  Enabled test for timeout as well
  Remaining work (not high pri for now)
   - Thread#raise without Exception parameters is not supported as it needs to 
access the active exception of the target thread. This is stored as a 
thread-local static, and so cannot be accessed from other threads. Can be fixed 
by not using ThreadStaticAttribute.
   - Adding probes (in generated code, in C# library code, etc) will help to 
raise the exception quicker as Thread.Abort can be delayed indefinitely. 
Ideally, we need both approaches. For now, using Thread.Abort goes a long way.
   - Ideally, we would add a try-catch to the IDynamicObject/MetaObject code 
paths so that when other languages called into Ruby code, they would get the 
expected user exception rather than a ThreadAbortException

  RunRSpec: supports -ruby to run with MRI. Its much faster than doing "rake 
ruby why_regression". Added support for -e to run a specific example


Attachment: raise.diff
Description: raise.diff

_______________________________________________
Ironruby-core mailing list
Ironruby-core@rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core

Reply via email to