File.dirname now uses [NotNull] instead of an explicit check on path: http://github.com/jschementi/ironruby/commit/8235f4861f0afb70c504472e697565080ffdb3c8 Jim said spec changes were fine. This is in my master github branch now, and Jim is pulling it in to the main repo shortly.
One more bug fix (autoload) left until Rails starts! From: Jim Deville Sent: Tuesday, April 14, 2009 11:45 AM To: Jimmy Schementi; ironruby-core@rubyforge.org Cc: IronRuby External Code Reviewers Subject: RE: Code Review: Allows symbols to be in a YAML array In the spec, why not use each_with_index instead of times? (http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609#L1R99) Other than that, looks good. JD From: Jimmy Schementi Sent: Saturday, April 11, 2009 4:42 PM To: ironruby-core@rubyforge.org Cc: IronRuby External Code Reviewers Subject: Code Review: Allows symbols to be in a YAML array http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609 Allows symbols to be in a YAML array ("date: [:year, :month, :day]"). Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375. (Shri: gitdiff wasn't working for me, is there any setup I need to do?)
_______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core