There is a setting in "git gui" I was thinking of, but it does not affect the github web view. Never mind...
From: Jim Deville Sent: Wednesday, April 15, 2009 5:14 PM To: Shri Borde Subject: RE: [Ironruby-core] [patch] More fixes for Array (IListOps.cs) There is no control over the context size on Github.... Unless I misunderstood your point From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Shri Borde Sent: Wednesday, April 15, 2009 4:14 PM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] [patch] More fixes for Array (IListOps.cs) In IListOps.Fetch, instead of doing the protocol conversion manually, you should calls Protocols. ConvertToInteger. Tomas, can you double-check this? In IListOps.First, you can get rid of the allocateStorage argument as its not being used anymore. (You can batch this fix with your next commit) The rest looks good! Great to see array getting more compliant! Btw, could you please increase the diff context size to 15-20 so more of the surrounding lines are included? That makes it easier to understand what the fix is doing when using the url below, without having to map that back to the correct line number in the actual file. Shri -----Original Message----- From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Daniele Alessandri Sent: Wednesday, April 15, 2009 9:31 AM To: ironruby-core@rubyforge.org Subject: [Ironruby-core] [patch] More fixes for Array (IListOps.cs) Hi, I've committed more fixes for a few methods of the Array class that were failing to pass the specs: http://github.com/nrk/ironruby/commit/b754ddcd3bdd2c4513e456c9cf3933772e8541f9 These are the specs affected by this patch: * core/array/compact - Array#compact keeps tainted status even if all elements are removed * core/array/delete - Array#delete may be given a block that is executed if no element matches object * core/array/first - Array#first does not return subclass instance when passed count on Array subclasses * core/array/last - Array#last does not return subclass instance on Array subclasses * core/array/flatten - Array#flatten returns subclass instance for Array subclasses - Array#flatten does not call flatten on elements * core/array/fetch - Array#fetch passes the original index argument object to the block, not the converted Integer I hope I haven't forgotten anything important this time, changes to the tags files are included in the commit :-) Regards, Daniele -- Daniele Alessandri http://www.clorophilla.net/blog/ http://twitter.com/JoL1hAHN _______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
_______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
