Hi,

>> The problem is in IoOps.ToPrintedString, where there is indeed an
>> obj.ToString() for doubles. Converting it with Convert.ToString(obj,
>> System.Globalization.CultureInfo.InvariantCulture) seems to fix the
>> issue, but I have just tried it in the REPL without running the test
>> suite yet. If you want, I can commit this fix in my repository if it
>> passes the tests.

I ran the whole irtests suite after applying the attached patch, based
on what Daniel described.

The good news is that the smoke tests now pass on my french machine.
Library / core errors remain unchanged (I included a log of the
remaining core errors in case someone has more time for this today).

cheers,

-- Thibaut
From Core RubyTests spec window:

1)
Float#/ properly handles BigDecimal argument ERROR
TypeError: BigDecimal can't be coerced into Float
:0:in `/'
divide_spec.rb:11
:0:in `instance_eval'
mspec.rb:64:in `protect'
context.rb:131:in `protect'
c:\git\ironruby\Merlin\Main\Languages\Ruby\Libraries.LCA_RESTRICTED\Builtins\Enumerable.cs:53:in
 `<TrueForItems>b__0'
:0:in `each'
c:\git\ironruby\Merlin\Main\Languages\Ruby\Libraries.LCA_RESTRICTED\Builtins\Enumerable.cs:34:in
 `Each'
c:\git\ironruby\Merlin\Main\Languages\Ruby\Libraries.LCA_RESTRICTED\Builtins\Enumerable.cs:51:in
 `TrueForItems'
:0:in `all?'
context.rb:129:in `protect'
context.rb:151:in `process'
:0:in `each'
context.rb:143:in `process'
mspec.rb:28:in `describe'
object.rb:10:in `describe'
divide_spec.rb:0
:0:in `load'
mspec.rb:54:in `files'
:0:in `instance_eval'
mspec.rb:64:in `protect'
mspec.rb:48:in `files'
:0:in `each'
mspec.rb:44:in `files'
mspec.rb:38:in `process'
mspec-ci.rb:59:in `run'
script.rb:189:in `main'
mspec-ci:0

2)
Time#_load loads local time FAILED
Expected dim. janv. 16 05:01:01 +01:00 2000
to equal sam. janv. 15 20:01:01  2000

expectations.rb:9:in `fail_with'
base.rb:6:in `=='
_load_spec.rb:39
:0:in `instance_eval'
mspec.rb:64:in `protect'
context.rb:131:in `protect'
c:\git\ironruby\Merlin\Main\Languages\Ruby\Libraries.LCA_RESTRICTED\Builtins\Enumerable.cs:53:in
 `<TrueForItems>b__0'
:0:in `each'
c:\git\ironruby\Merlin\Main\Languages\Ruby\Libraries.LCA_RESTRICTED\Builtins\Enumerable.cs:34:in
 `Each'
c:\git\ironruby\Merlin\Main\Languages\Ruby\Libraries.LCA_RESTRICTED\Builtins\Enumerable.cs:51:in
 `TrueForItems'
:0:in `all?'
context.rb:129:in `protect'
context.rb:151:in `process'
:0:in `each'
context.rb:143:in `process'
mspec.rb:28:in `describe'
object.rb:10:in `describe'
_load_spec.rb:0
:0:in `load'
mspec.rb:54:in `files'
:0:in `instance_eval'
mspec.rb:64:in `protect'
mspec.rb:48:in `files'
:0:in `each'
mspec.rb:44:in `files'
mspec.rb:38:in `process'
mspec-ci.rb:59:in `run'
script.rb:189:in `main'
mspec-ci:0

Finished in 491.265625 seconds

1125 files, 4389 examples, 15954 expectations, 1 failure, 1 error

Attachment: ioops.diff
Description: Binary data

_______________________________________________
Ironruby-core mailing list
Ironruby-core@rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core

Reply via email to