Hi,
It would be nice to have anyone to review my code :-). bug file in at http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1021

Thanks,
-Jirapong

On May 4, 2009, at 8:43 AM, Jimmy Schementi wrote:

Doesn’t look like anyone has reviewed this yet. To make sure it doesn’t get lost, can you also make a bug on codeplex for this?

From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org ] On Behalf Of jirapong.na...@gmail.com
Sent: Friday, April 24, 2009 1:56 PM
To: ironruby-core@rubyforge.org
Subject: [Ironruby-core] Time class instance

Hi
Time class instance in IronRuby act as static. Given following code:

t = Time.new
t.utc
t.utc? # should be true behave

t.localtime
t.utc? # should be false

"t" should convert itself into UTC type after method "utc" being called. There are three methods must modifying the receiver; utc, gmtime, and localtime

It also effect to Time.rfc2882 formating as you can run MRI vs IronRuby at - http://gist.github.com/101229

I have propose my fix at - 
http://github.com/Jirapong/ironruby/commit/937a8c4aea048dd20ddea8aa6e27b0055bf6907d

File changes:
• Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ ironruby-tags/library/time/rfc2822_tags.txt • Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ rubyspec/core/time/utc_spec.rb • Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/ Builtins/FileOps.cs • Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/ Builtins/TimeOps.cs • Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/ Initializers.Generated.cs • Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Zlib/ zlib.cs
          • Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyDateTime.cs
          • Merlin/Main/Languages/Ruby/Ruby/Ruby.csproj

Note: Shri, this push should fix
23) Failure:
test_request_unmodifed(TestGemRemoteFetcher) [test_gem_remote_fetcher.rb:604]: Expected "Mon, 13 Apr 2009 13:22:16 -0700", not "Mon, 13 Apr 2009 20:22:16 -0000"

Thank you,
-Jirapong
_______________________________________________
Ironruby-core mailing list
Ironruby-core@rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core

_______________________________________________
Ironruby-core mailing list
Ironruby-core@rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core

Reply via email to