Looks good!

From: ironruby-core-boun...@rubyforge.org 
[mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Tim Chen (SDO)
Sent: Tuesday, May 12, 2009 12:12 AM
To: ironruby-core@rubyforge.org
Subject: Re: [Ironruby-core] Review: Array\to_s fix for : properly handles 
recursive array



It is the first time I modify the ruby source :) so sorry for the ignorance.

I would change those and push them again.

Thanks for the feedback!

Tim
________________________________
From: ironruby-core-boun...@rubyforge.org [ironruby-core-boun...@rubyforge.org] 
on behalf of jirapong.na...@gmail.com [jirapong.na...@gmail.com]
Sent: Monday, May 11, 2009 7:11 PM
To: ironruby-core@rubyforge.org
Subject: Re: [Ironruby-core] Review: Array\to_s fix for : properly handles 
recursive array
Hello Tim,
I would like to share experience about code convention with you. You should set 
a braces on Same Line option 
(http://www.knowdotnet.com/articles/toolsoptionsnewlinesbraces.html).

Cheers,
-Jirapong

On May 12, 2009, at 8:03 AM, Tim Chen (SDO) wrote:


Forgot to mention that I deleted the tag files that has no more tags in it.

Tim

From: 
ironruby-core-boun...@rubyforge.org<mailto:ironruby-core-boun...@rubyforge.org> 
[mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Tim Chen (SDO)
Sent: Monday, May 11, 2009 6:02 PM
To: ironruby-core@rubyforge.org<mailto:ironruby-core@rubyforge.org>
Subject: [Ironruby-core] Review: Array\to_s fix for : properly handles 
recursive array

http://github.com/tnachen/ironruby/commit/eeaf82a8d833c763fc617b602cd7415cb228a0f6

Modified IListOps to fix the recursive array problem during to_s call.

It used to only print the values in the array, and skip over arrays in the 
array that contains the same values.

However, to conform with mri, I modified it so it will walk into the array and 
print the values for only one level deep, then print the remaining arrays with 
"[...]".

Files Changed:

 *   
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/array/to_s_tags.txt
  (deleted)
 *   
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/env/clear_tags.txt
 (deleted)
 *   Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs 
(modified)

Thank you!
Tim




_______________________________________________
Ironruby-core mailing list
Ironruby-core@rubyforge.org<mailto:Ironruby-core@rubyforge.org>
http://rubyforge.org/mailman/listinfo/ironruby-core

_______________________________________________
Ironruby-core mailing list
Ironruby-core@rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core

Reply via email to