Changes look good overall. I'm not sure that Type.IsProtected() is an intuitive name; maybe Type.IsNested() would be clearer?
-----Original Message----- From: Tomas Matousek Sent: Saturday, June 06, 2009 12:51 PM To: IronRuby External Code Reviewers; Rowan Code Reviewers Cc: [email protected] Subject: Code Review: ProGenFix tfpt review "/shelveset:ProGenFix;REDMOND\tomat" DLR, Python, Ruby. Fixes Ruby calls to protected generic methods. Adds CompilerHelpers.IsProtected() as an alias for IsFamily || IsFamilyOrAssembly. Tomas _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
